Skip to content

Add DefaultFullHttpResponse to Netty Check #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Add DefaultFullHttpResponse to Netty Check #2764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832a4f2
Add DefaultFullHttpResponse to Netty Check
JLLeitschuh Feb 4, 2020
60f2fa9
Update java/ql/src/Security/CWE/CWE-113/NettyResponseSplitting.ql
JLLeitschuh Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions java/ql/src/Security/CWE/CWE-113/NettyResponseSplitting.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,12 @@ private class InsecureDefaultHttpResponseClassInstantiation extends InsecureNett
}
}

private class InsecureDefaultFullHttpResponseClassInstantiation extends InsecureNettyObjectCreation {
InsecureDefaultFullHttpResponseClassInstantiation() {
getConstructedType().hasQualifiedName("io.netty.handler.codec.http", "DefaultFullHttpResponse") and
getArgument(3).(CompileTimeConstantExpr).getBooleanValue() = false
}
}

from InsecureNettyObjectCreation new
select new, "Response-splitting vulnerability due to header value verification being disabled."