Skip to content

Conversation

aschackmull
Copy link
Contributor

No description provided.

final private class FinalBasicBlock = BasicBlock;

module Cfg implements BB::CfgSig<DbLocation> {
private import javascript as Js

Check warning

Code scanning / CodeQL

Names only differing by case

Js is only different by casing from js that is used elsewhere for modules. Js is only different by casing from JS that is used elsewhere for modules.
deprecated private predicate lastRefSkipUncertainReadsExt(
Definition def, SsaInput::BasicBlock bb, int i
) {
deprecated private predicate lastRefSkipUncertainReadsExt(Definition def, BasicBlock bb, int i) {

Check warning

Code scanning / CodeQL

Missing QLDoc for parameter

The QLDoc has no documentation for bb, or def, or i, but the QLDoc mentions lastRefRedef
this.hasValueBranchEdge(bb1, bb2, branch)
}
}

/** Holds if the guard `guard` controls block `bb` upon evaluating to `branch`. */
predicate guardDirectlyControlsBlock(Guard guard, SsaInput::BasicBlock bb, GuardValue branch) {
predicate guardDirectlyControlsBlock(Guard guard, BasicBlock bb, GuardValue branch) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
@aschackmull aschackmull force-pushed the shared/basicblock-signature3 branch from 72df720 to b548685 Compare September 1, 2025 08:14
@aschackmull aschackmull closed this Sep 1, 2025
@aschackmull aschackmull deleted the shared/basicblock-signature3 branch September 1, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant