Skip to content

Ruby: Do not compute StringlikeLiteralImpl.getStringValue for large strings #19926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Ruby: Do not compute StringlikeLiteralImpl.getStringValue for large strings #19926

merged 1 commit into from
Jul 1, 2025

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Jun 30, 2025 •
edited
Loading

Fixes the PoolGrowthError "String too long (2160871 characters)" error we have seen at a customer.

@github-actions github-actions bot added the Ruby label Jun 30, 2025
@hvitved hvitved force-pushed the ruby/restrict-string-component-length branch from 550f14c to 41a403c Compare June 30, 2025 11:02
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jun 30, 2025
@hvitved hvitved marked this pull request as ready for review June 30, 2025 17:57
Copilot AI review requested due to automatic review settings June 30, 2025 17:57
@hvitved hvitved requested a review from a team as a code owner June 30, 2025 17:57
Copilot AI reviewed Jun 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@hvitved hvitved requested a review from asgerf July 1, 2025 07:04
aibaars
aibaars approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@hvitved hvitved merged commit 219a622 into github:main Jul 1, 2025
28 checks passed
@hvitved hvitved deleted the ruby/restrict-string-component-length branch July 1, 2025 10:45
@evK1
Copy link

evK1 commented Jul 3, 2025

Thanks for fixing this!

Ditto !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@asgerf asgerf Awaiting requested review from asgerf

+1 more reviewer

@aibaars aibaars aibaars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-change-note-required This PR does not need a change note Ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hvitved @evK1 @aibaars