Ruby: Adopt shared SSA data-flow integration #16937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
ruby/ssa-integration
branch
from
269c760 to
5ccc46d
Compare
shared/ssa/codeql/ssa/Ssa.qll
Outdated
Comment on lines
1329
to
1332
| e = DfInput::getARead(_) | ||
| or | ||
| DfInput::ssaDefAssigns(_, e) and | ||
| isPost = false |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct.
hvitved
force-pushed
the
ruby/ssa-integration
branch
2 times, most recently
from
bc543bc to
1090f52
Compare
shared/ssa/codeql/ssa/Ssa.qll
Outdated
Comment on lines
1330
to
1339
| e = DfInput::getARead(_) | ||
| or | ||
| DfInput::ssaDefAssigns(_, e) and | ||
| isPost = false |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct.
hvitved
force-pushed
the
ruby/ssa-integration
branch
2 times, most recently
from
7280dbc to
e17c067
Compare
Comment on lines
1356
to
1340
| e = DfInput::getARead(_) | ||
| or | ||
| exists(DefinitionExt def | | ||
| DfInput::ssaDefAssigns(def, e) and | ||
| hasCertainRead(def) and | ||
| isPost = false | ||
| ) |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct.
hvitved
force-pushed
the
ruby/ssa-integration
branch
from
4ff0306 to
6290a2d
Compare
|
|
||
| private newtype TNode = | ||
| TParamNode(DfInput::Parameter p) { | ||
| exists(WriteDefinition def | DfInput::ssaDefInitializesParam(def, p)) |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable
hvitved
force-pushed
the
ruby/ssa-integration
branch
from
6290a2d to
9263977
Compare
aschackmull
approved these changes
Jul 19, 2024
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
Looks plausible to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the newly introduced shared SSA data-flow integration layer.