Java: Adopt shared SSA library #16900

hvitved · 2024-07-03T19:24:34Z

No description provided.

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowNodes.qll

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll

java/ql/lib/semmle/code/java/dataflow/SSA.qll

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll

java/ql/src/Violations of Best Practice/Dead Code/DeadLocals.qll

-  not exists(SsaImplicitInit init | init.captures(ssa)) and
-  not emptyDecl(ssa) and
-  not readImplicitly(ssa, _)
+/** A dead variable update. */


java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll

shared/ssa/codeql/ssa/Ssa.qll

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll

shared/ssa/codeql/ssa/Ssa.qll

+
+    private newtype TNode =
+      TParamNode(DfInput::Parameter p) {
+        exists(WriteDefinition def | DfInput::ssaDefInitializesParam(def, p))


java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll

+    Location getLocation() { result = super.getLocation() }
+
+    predicate hasCfgNode(BasicBlock bb, int i) {
+      super.getControlFlowNode() = bb.(J::BasicBlock).getNode(i)


Some fixes to github#16900

aschackmull

LGTM

Did extensive black-box testing comparing this to the prior implementation. Discrepancies of course occurred for dead variables, but there were also a tiny few other discrepancies: some use-use differences related to unreachable code, which makes sense, and a few getPriorDef differences that were too minor to investigate further.

java/ql/lib/semmle/code/java/dataflow/SSA.qll

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll

aschackmull · 2025-02-10T11:57:32Z

Added two join-order fixes as inline suggestions.

aschackmull · 2025-02-11T07:58:14Z

We need a small tweak, as we currently have a semantic merge conflict with #18729.

…rUpdate.

Co-authored-by: Anders Schack-Mulligen <[email protected]>

github-actions bot added the Java label Jul 3, 2024

github-advanced-security bot found potential problems Jul 3, 2024

View reviewed changes

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowNodes.qll Fixed Show fixed Hide fixed

hvitved force-pushed the java/shared-ssa branch 3 times, most recently from 1d5e5ac to 551238a Compare July 5, 2024 13:36

github-advanced-security bot found potential problems Jul 5, 2024

View reviewed changes

hvitved force-pushed the java/shared-ssa branch from 551238a to 291e278 Compare July 8, 2024 09:08

github-advanced-security bot found potential problems Jul 8, 2024

View reviewed changes

hvitved force-pushed the java/shared-ssa branch from 291e278 to 4f5d6e3 Compare July 8, 2024 11:43

github-advanced-security bot found potential problems Jul 8, 2024

View reviewed changes

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll Fixed Show fixed Hide fixed

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll Fixed Show fixed Hide fixed

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll Fixed Show fixed Hide fixed

hvitved force-pushed the java/shared-ssa branch 2 times, most recently from 4479e03 to a93188c Compare July 8, 2024 18:55

github-advanced-security bot found potential problems Jul 8, 2024

View reviewed changes

shared/ssa/codeql/ssa/Ssa.qll Fixed Show fixed Hide fixed

hvitved force-pushed the java/shared-ssa branch from 132d68c to 5cdb692 Compare July 9, 2024 10:59

hvitved mentioned this pull request Jul 9, 2024

SSA: Add data flow integration layer #16884

Merged

hvitved changed the title ~~Java: Adopt shared SSA data-flow integration (WIP)~~ Java: Adopt shared SSA library Jul 9, 2024

hvitved force-pushed the java/shared-ssa branch 2 times, most recently from ab9d191 to 910f049 Compare July 10, 2024 07:45

github-advanced-security bot found potential problems Jul 10, 2024

View reviewed changes

shared/ssa/codeql/ssa/Ssa.qll Fixed Show fixed Hide fixed

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll Fixed Show fixed Hide fixed

shared/ssa/codeql/ssa/Ssa.qll Fixed Show fixed Hide fixed

hvitved force-pushed the java/shared-ssa branch 3 times, most recently from 4db2c2b to 3d63764 Compare July 11, 2024 09:38

github-advanced-security bot found potential problems Jul 11, 2024

View reviewed changes

shared/ssa/codeql/ssa/Ssa.qll Fixed Show fixed Hide fixed

hvitved force-pushed the java/shared-ssa branch 2 times, most recently from 308fce2 to de69820 Compare July 11, 2024 19:37

github-advanced-security bot found potential problems Jul 11, 2024

View reviewed changes

shared/ssa/codeql/ssa/Ssa.qll Fixed Show fixed Hide fixed

hvitved force-pushed the java/shared-ssa branch from 555c5cd to d985bee Compare July 12, 2024 09:07

github-advanced-security bot found potential problems Jul 12, 2024

View reviewed changes

hvitved force-pushed the java/shared-ssa branch from d985bee to 38f5b0b Compare July 12, 2024 12:24

MathiasVP mentioned this pull request Sep 12, 2024

PS: SSA skeleton and various fixes microsoft/codeql#93

Merged

hvitved force-pushed the java/shared-ssa branch from 38f5b0b to bc36ffe Compare September 20, 2024 06:43

hvitved force-pushed the java/shared-ssa branch from bc36ffe to 664708f Compare November 5, 2024 12:58

hvitved force-pushed the java/shared-ssa branch from 664708f to 9f3a577 Compare December 18, 2024 10:27

github-advanced-security bot found potential problems Dec 18, 2024

View reviewed changes

hvitved added a commit to hvitved/codeql that referenced this pull request Feb 10, 2025

Merge pull request #7 from aschackmull/java/shared-ssa-fixes

f8c0c6f

Some fixes to github#16900

aschackmull previously approved these changes Feb 10, 2025

View reviewed changes

aschackmull reviewed Feb 10, 2025

View reviewed changes

java/ql/lib/semmle/code/java/dataflow/SSA.qll Show resolved Hide resolved

aschackmull reviewed Feb 10, 2025

View reviewed changes

java/ql/lib/semmle/code/java/dataflow/SSA.qll Outdated Show resolved Hide resolved

aschackmull reviewed Feb 10, 2025

View reviewed changes

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll Outdated Show resolved Hide resolved

hvitved dismissed aschackmull’s stale review via b093ae9 February 10, 2025 12:09

aschackmull previously approved these changes Feb 10, 2025

View reviewed changes

hvitved marked this pull request as ready for review February 10, 2025 20:49

hvitved requested a review from a team as a code owner February 10, 2025 20:49

hvitved added the no-change-note-required This PR does not need a change note label Feb 10, 2025

hvitved and others added 6 commits February 11, 2025 10:06

Java: Adopt shared SSA library

75137a0

Java: Fixup private

284e48c

Java: Bugfix for qualifier-of-qualifier update in hasExplicitQualifie…

ed28435

…rUpdate.

Java: Bugfix for samevar in useReaches.

e955f58

Apply suggestions from code review

6fbb1e2

Co-authored-by: Anders Schack-Mulligen <[email protected]>

Java: Remove ExitBasicBlock from SsaInput

e5e8843

hvitved dismissed aschackmull’s stale review via e5e8843 February 11, 2025 09:08

hvitved force-pushed the java/shared-ssa branch from b093ae9 to e5e8843 Compare February 11, 2025 09:08

hvitved requested a review from aschackmull February 11, 2025 09:35

aschackmull approved these changes Feb 11, 2025

View reviewed changes

hvitved merged commit a061b1e into github:main Feb 11, 2025
15 checks passed

hvitved deleted the java/shared-ssa branch February 11, 2025 10:04

Java: Adopt shared SSA library #16900

Java: Adopt shared SSA library #16900

Uh oh!

Conversation

hvitved commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

aschackmull left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aschackmull commented Feb 10, 2025

Uh oh!

aschackmull commented Feb 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aschackmull left a comment •

edited

Loading