feat: target net9 for GE 6.0 #89
Conversation
add .editorconfig from GE to suppress WFO1000 The complete config is included, with many settings.
README.md
Outdated
| | 4.0.1 <= v <= 4.0.2 | 2.0.5 | | ||
| | 4.1.x <= v <= 4.2.0 | 2.0.6 <= v | | ||
| | 4.2.x <= v <= 5.0.0 | 2.0.7 <= v | | ||
| | 5.0.x <= v | 3.0.0 <= v | |
There was a problem hiding this comment.
| | 5.0.x <= v | 3.0.0 <= v | | |
| | 5.0.x <= v <= 6.0.0 | 3.0.0 <= v | |
| | 4.1.x <= v <= 4.2.0 | 2.0.6 <= v | | ||
| | 4.2.x <= v <= 5.0.0 | 2.0.7 <= v | | ||
| | 5.0.x <= v | 3.0.0 <= v | | ||
| | 6.0.1 <= v | 3.1.0 <= v | |
There was a problem hiding this comment.
| | 6.0.1 <= v | 3.1.0 <= v | | |
| | 6.0.x <= v | 3.1.0 <= v | |
|
Thanks @gerhardol ! |
|
Will update GitExtensions.Extensibility to 0.3.3 (likely) too. |
update version of GitExtensions.Extensibility to merged version add .editorconfig from GE to suppress WFO1000 The complete config is included, with many settings.
|
It looks like GitExtensions.Extensibility version 0.4.0.106 hasn’t been published yet: |
The publish failed due to an expired token, waiting for it to be updated. |
|
Package is now being published https://www.nuget.org/packages/GitExtensions.Extensibility/0.4.0.111 |
|
Thanks @maraf! |
|
It builds, but GitExtensions.Extensibility.dll still seem to be ld so not updated. |
|
Still not working, some discussion in gitextensions/gitextensions.pluginmanager#82 |
|
@gitextensions/git-extensions-team This is still a blocker for 6.0.1 - at least one plugin should be OK |
|
Apologies, what's blocked? I thought it was resolved with gitextensions/gitextensions.pluginmanager#82 |
The build in this PR uses the old version of GitExtensions.Extensibility |
|
The PR updates the Extensibility package to 0.4.* and for the assembly, it has instructions to download latest https://github.com/gitextensions/GitExtensions.GerritPlugin/blob/master/src%2FGitExtensions.GerritPlugin%2FGitExtensions.GerritPlugin.csproj.user#L7. It should be all that is needed. Where do you see old version? |
When I downloaded the artifact for this PR and put that in UserPlugins, I got the popup about the missing API that should be resolved by the update |
|
Okay, I can repro it as well EDIT: It doesn't happen when I build this branch locally |
|
@gerhardol It should be resolved now |
|
Thanks @maraf ! |
add .editorconfig from GE to suppress WFO1000
The complete config is included, with many settings.
No usage at all.
Note that with upcoming 6.0.1, you get a popup due to a changed API.
The plugin may work before, but not applying the dark theme
(may be required manually also targetting .net9, all untested).
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Support GitExtensions 6.0
What is the current behavior?
Popup and no dark mode, unknown with GE6
What is the new behavior?
No popup but still unknown.
Does this PR introduce a breaking change?
New .net9, new GE version
Other information