clear PIN_EXTERNAL_FLAG before PCNT channel config #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case I need to do some extra actions with direction change, so I use mcu dir_pin with external flag. But in that case the PCNT module gets "wrong" direction pin from getDirectionPin() and the pin freezes in its state.
Took some time to determine why pin freezes.
So external flag clearing solves the problem.
(tested on IDF5 but assume that IDF4 has the same problem)