Updated to use 'docker' module

[mjbright]

No longer use obsolete 'docker-py' version

The Python 'docker' module is now at version 2.2.1 and has changed significantly since the 'docker-py' 1.10 version.

This minor change allows python-docker-machine to work with the current module.

Note: previously installing python-docker-machine was rendering existing 'docker' module unusable as 'docker-py' would be installed.

[gijzelaerr]

Hi @mjbright! thanks

Did you run the test suite? Didn't the API change in a backwards incompatible way? I didn't manage to get the travis test suite run to work and I can't run it at the moment.

[mjbright]

Oops, no ... didn't realize there was a test suite. I was pleasantly surprised that my use cases ran with just this small change. Note: Uninstalling docker-py was insufficient for me. I created a new anaconda3 environment, did a "pip install docker", then a "python setup.py install" of this module. I'll have a look at the test suite this weekend.

…

On 5 May 2017 at 09:30, Gijs Molenaar ***@***.***> wrote: Hi @mjbright <https://github.com/mjbright>! thanks Did you run the test suite? Didn't the API change in a backwards incompatible way? I didn't manage to get the travis test suite run to work and I can't run it at the moment. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABywLarizdqMD40x62jcRhW1Lr9h4AMuks5r2tAegaJpZM4NRDVX> .

[mjbright]

I ran the nosetests which failed on access to docker.Client.

Updating this to docker.APIClient allowed all tests, including "skipped" tests, to pass.

Tested with docker-machine-0.11 on Ubuntu 16.04.2 LTS with Anaconda (conda v4.3.14).
Tested with docker-machine-0.9 on Fedora 24 with Anaconda (conda v4.3.14).

I was unable to run the tox tests in both environments (basic misunderstanding on my part I believe).

[gijzelaerr]

thanks! did you try with python3? i'm getting an error:

λ  .virtualenv/bin/nosetests
.E..SS...................
======================================================================
ERROR: test_config (test_commands.TestCommands)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/gijs/Work/python-docker-machine/tests/test_commands.py", line 46, in test_config
    client = docker.APIClient(**config)
AttributeError: module 'docker' has no attribute 'APIClient'

----------------------------------------------------------------------
Ran 25 tests in 337.889s

FAILED (SKIP=2, errors=1)

[mjbright]

Yes, I tested with Python3. I think you don't have the latest "docker" module which is version 2..2.1

…

On 8 May 2017 at 11:24, Gijs Molenaar ***@***.***> wrote: thanks! did you try with python3? i'm getting an error: λ .virtualenv/bin/nosetests .E..SS................... ====================================================================== ERROR: test_config (test_commands.TestCommands) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/gijs/Work/python-docker-machine/tests/test_commands.py", line 46, in test_config client = docker.APIClient(**config) AttributeError: module 'docker' has no attribute 'APIClient' ---------------------------------------------------------------------- Ran 25 tests in 337.889s FAILED (SKIP=2, errors=1) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABywLdL8oo6qoUx9b6YMYU4CPllmcXDWks5r3t81gaJpZM4NRDVX> .

[AnTuanHa]

@gijzelaerr Will this be merged? @mjbright's changes looks good to me and works fine on my machine.

I ran the nosetests for python2.7, python3.6 and pypy on Arch Linux. All tests passed (2 were skipped)

[gijzelaerr]

yes, it looks fine with python3. Sorry for the delay guys, i will amke a new release.