Skip to content

sycl: add PAD_REFLECT_D1 operator support #16145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2025
Merged

sycl: add PAD_REFLECT_D1 operator support #16145

merged 5 commits into from
Oct 20, 2025

Conversation

@ye-NX
Copy link
Contributor

@ye-NX ye-NX commented Sep 21, 2025

Title: Add SYCL backend support for PAD_REFLECT_1D

Description:
This PR adds a SYCL implementation of the PAD_REFLECT_1D operator:

  • Implements pad_reflect_d1_f32 kernel for F32 tensors.
  • Adds ggml_sycl_op_pad_reflect_d1 launcher and backend dispatch.
  • Verified correctness with test-backend-ops.

This enables reflection padding along the first dimension to run on GPU devices using SYCL, improving operator coverage and reducing CPU fallbacks.

@github-actions github-actions bot added documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Sep 21, 2025
@ye-NX
Copy link
Contributor Author

ye-NX commented Oct 16, 2025

Hi @NeoZhangJianyu and @slaren,
I've opened two related SYCL PRs:

Would appreciate it if you could take a look when you have a moment.
Thanks!

NeoZhangJianyu
NeoZhangJianyu approved these changes Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good work!

Thank you!

@NeoZhangJianyu
Copy link
Collaborator

NeoZhangJianyu commented Oct 17, 2025

@ye-NX
Please resolve the conflicts!

Thank you!

@ye-NX ye-NX force-pushed the ye/sycl-pad-reflect-d1 branch from 2fcbaf3 to 08268f0 Compare October 19, 2025 11:21
@ye-NX
Copy link
Contributor Author

ye-NX commented Oct 19, 2025

@NeoZhangJianyu
Thank you for reviewing!
I’ve resolved the merge conflicts and updated the branch.
Could you please check if everything looks good now?

@CISC
Copy link
Collaborator

CISC commented Oct 19, 2025

Could you please check if everything looks good now?

You need to regenerate docs/ops.md.

@ye-NX
Copy link
Contributor Author

ye-NX commented Oct 20, 2025

@CISC

You need to regenerate docs/ops.md.
I've done it. Thanks!

@CISC
Copy link
Collaborator

CISC commented Oct 20, 2025

You need to regenerate docs/ops.md.
I've done it. Thanks!

Rebase to fix the update-ops-docs CI error, and fix the whitespace issues:
https://github.com/ggml-org/llama.cpp/actions/runs/18648622295/job/53161469102?pr=16145

@ye-NX ye-NX force-pushed the ye/sycl-pad-reflect-d1 branch from 2b9bb5d to d469c5b Compare October 20, 2025 10:31
CISC
CISC reviewed Oct 20, 2025
View reviewed changes
CISC
CISC reviewed Oct 20, 2025
View reviewed changes
@ye-NX
Copy link
Contributor Author

ye-NX commented Oct 20, 2025

@CISC
I think it's fine now, can you check it?

CISC
CISC reviewed Oct 20, 2025
View reviewed changes
@CISC CISC merged commit 6de8ed7 into ggml-org:master Oct 20, 2025
70 of 71 checks passed
@ye-NX
Copy link
Contributor Author

ye-NX commented Oct 20, 2025

Thank you!!

FMayran pushed a commit to FMayran/llama.cpp that referenced this pull request Oct 23, 2025
@ye-NX
sycl : add PAD_REFLECT_D1 operator support (ggml-org#16145)
6976e5b 
* sycl: add PAD_REFLECT_D1 operator support

* docs(ops): regenerate docs/ops.md

* remove trailing whitespaces

* style: fix editorconfig issues — trim trailing spaces and normalize EOLs

* fix: move PAD_REFLECT_1D case outside of fall-through block
pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request Oct 23, 2025
@ye-NX @pwilkin
sycl : add PAD_REFLECT_D1 operator support (ggml-org#16145)
c50d04c 
* sycl: add PAD_REFLECT_D1 operator support

* docs(ops): regenerate docs/ops.md

* remove trailing whitespaces

* style: fix editorconfig issues — trim trailing spaces and normalize EOLs

* fix: move PAD_REFLECT_1D case outside of fall-through block
@ye-NX ye-NX deleted the ye/sycl-pad-reflect-d1 branch October 30, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC left review comments

@NeoZhangJianyu NeoZhangJianyu NeoZhangJianyu approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ye-NX @NeoZhangJianyu @CISC