feat(uptime): add more metrics to uptime checker for check delays #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will now record: - the difference between when a check was enqueued to the executor, and the start of the tick. - the difference between when a check began executing, and when it was enqueued to the executor. This should allow us more insight into how a check "flows" through the system, and where we are incurring delays
| /// The number of times this scheduled check has been retried | ||
| retry_count: u16, | ||
|
|
||
| // The utc timestamp this check was sent to the executor queue. |
There was a problem hiding this comment.
aren't unix timestamps always UTC heh
There was a problem hiding this comment.
But I didn't specify it was a unix timestamp :)
wedamija
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will now record: