[sidekiq] better and isolated rails specs #2723
                
     Open
            
            
          
      
        
          +24
        
        
          −21
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This updates sidekiq spec setup to be inline with other projects by adding
spec:isolatedgroup and movingrails_spec.rbthere because it is meant to be run in isolation wheresentry-railsis required.While working on this I also discovered that there's spec flakiness here due to the fact that
redispatch is enabled by default and spec require order would make some specs randomly fail under Sidekiq <= 6.5. I fixed it by removingredisfrom default patches in the test config but I am wondering why this patch is enabled be default?#skip-changelog