- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 517
Don't gate request query strings and form data behind send_default_pii #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Migrate from to_hash to to_h As @solnic pointed out in #2350 (comment) `to_hash` has special meaning in Ruby and could be called implicitly in contexts like double splatting argument. So we should switch to `to_h` to avoid potential issues.
78c4fe5    to
    f1c1f1f      
    Compare
  
    | Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
- Coverage   98.16%   98.06%   -0.10%     
==========================================
  Files         126      126              
  Lines        4741     4708      -33     
==========================================
- Hits         4654     4617      -37     
- Misses         87       91       +4     
 
 🚀 New features to boost your workflow:
 | 
f1c1f1f    to
    93644c7      
    Compare
  
    55bbe4d    to
    ca51cc7      
    Compare
  
    ca51cc7    to
    c6d6137      
    Compare
  
    | The failing test seems to be about new behavior rails 7.2 and will be fixed separately | 
| Query strings should not be guarded by  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think send_default_pii should be applied to body.
| category: self.class::BREADCRUMB_CATEGORY, | ||
| type: :info, | ||
| data: { status: response_status, **request_info } | ||
| data: { status: response_status, **request_info.compact } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this should be called at the caller's extract_request_info helpers.
179dd87    to
    6e39d31      
    Compare
  
    
This makes it consistent with behavior in other SDKs.
But since it changes behavior, we will release it as part of the next major.