Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Oct 31, 2025

Enabling eslint rules for RegEx in dev-packages.

This is a part of this (now closed) PR: #18053

The first commit contains all changes that were automatically made with --fix, the second commit contains the manual changes.

@s1gr1d s1gr1d requested a review from a team as a code owner October 31, 2025 09:35
@s1gr1d s1gr1d requested review from AbhiPrasad, Lms24 and andreiborza and removed request for a team October 31, 2025 09:36
cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,533 - 8,887 +7%
GET With Sentry 1,435 15% 1,427 +1%
GET With Sentry (error only) 6,184 65% 6,176 +0%
POST Baseline 1,220 - 1,195 +2%
POST With Sentry 528 43% 506 +4%
POST With Sentry (error only) 1,073 88% 1,068 +0%
MYSQL Baseline 3,395 - 3,336 +2%
MYSQL With Sentry 511 15% 580 -12%
MYSQL With Sentry (error only) 2,740 81% 2,720 +1%

View base workflow run

@s1gr1d s1gr1d merged commit 1a7189d into develop Nov 6, 2025
194 of 196 checks passed
@s1gr1d s1gr1d deleted the sig/regex-eslint-rules-dev-packages branch November 6, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants