fix(sveltekit): Ensure server errors from streamed responses are sent #17044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Lms24
requested review from
a team,
AbhiPrasad and
chargome
and removed request for
a team
3 tasks
Lms24
changed the title
AbhiPrasad
approved these changes
Jul 16, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SvelteKit, users can return a
Promisefrom aloadfunction which causes a streamed http respnse to be sent. If the promise rejects after it is returned and the initial response is sent, an error is thrown server-side. This error will not be captured by our request handler wrappers because at this time, they already finished.However, the error will be caught via our
handleErrorWithSentryhook. This means we actually still catch the error but because the cloudflare function already terminated directly after the rejection, it is not sent successfully (i.e. the good old flush problem).This PR makes sure we use of Cloudflare's
waitUntilfunction which fortunately is available within the error handler hook.closes #17009