-
-
Notifications
You must be signed in to change notification settings - Fork 220
feat(logs): initial API for Sentry Logs #4158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Sentry/Experimental/System.Diagnostics.CodeAnalysis.ExperimentalAttribute.cs
Outdated
Show resolved
Hide resolved
Exciting first step in our logging story :) |
@Flash0ver can we reference some developer docs and/or an issue in the PR description to help reviewers get an overview of the change before looking at code? |
test/Sentry.DiagnosticSource.IntegrationTests/SqlListenerTests.verify.cs
Outdated
Show resolved
Hide resolved
Looking good so far 👍🏻 |
…sentry-dotnet into feat/logs-initial-api
This was referenced Aug 1, 2025
Flash0ver
added a commit
that referenced
this pull request
Aug 7, 2025
* feat(logs): initial API for Sentry Logs (#4158) * feat(logs): add Buffering and Batching (#4310) * feat(logs): Logs for `Sentry.Extensions.Logging` and integrations for `Sentry.AspNetCore` and `Sentry.Maui` (#4193) Co-authored-by: Bruno Garcia <[email protected]> Co-authored-by: James Crosswell <[email protected]> Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
This was referenced Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
TODO
Follow-ups
object[]
but generic<TArg>
overloads per Log-Severity method for the most common scenariosoptions.EnableLogs is false
IDiagnosticLogger.Log{Level}()
extension methods have overloads with up to 3 generic type parametersString.Format
has 1-3 object argumentsnet8.0
when used withCompositeFormat
[InterpolatedStringHandler]
to support interpolated strings and ensure zero-alloc ifoptions.EnableLogs is false
net6.0
log
Envelope Item PayloadEarly feedback appreciated on- public APIssee also Question-Comments in the draft