Skip to content

Conversation

Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented Apr 30, 2025

Info

TODO

  • Complete public API surface area
  • XML API docs
  • Add Tests

Follow-ups

  • Add non object[] but generic <TArg> overloads per Log-Severity method for the most common scenarios
    • to avoid both boxing allocations and array allocations in case options.EnableLogs is false
    • our public IDiagnosticLogger.Log{Level}() extension methods have overloads with up to 3 generic type parameters
    • .NET's String.Format has 1-3 object arguments
      • and 1-3 generic arguments since net8.0 when used with CompositeFormat
  • Consider a custom [InterpolatedStringHandler] to support interpolated strings and ensure zero-alloc if options.EnableLogs is false
    • available for TFMs compatible with net6.0
  • Batching, via log Envelope Item Payload
  • Integrate into Sentry.Extensions.Logging
  • Experimental docs

Early feedback appreciated on
- public APIs

see also Question-Comments in the draft

@Flash0ver Flash0ver self-assigned this Apr 30, 2025
@bruno-garcia
Copy link
Member

Exciting first step in our logging story :)

@jamescrosswell
Copy link
Collaborator

@Flash0ver can we reference some developer docs and/or an issue in the PR description to help reviewers get an overview of the change before looking at code?

@jamescrosswell
Copy link
Collaborator

Looking good so far 👍🏻

@Flash0ver Flash0ver deleted the feat/logs-initial-api branch June 25, 2025 17:52
Flash0ver added a commit that referenced this pull request Aug 7, 2025
* feat(logs): initial API for Sentry Logs (#4158)
* feat(logs): add Buffering and Batching (#4310)
* feat(logs): Logs for `Sentry.Extensions.Logging` and integrations for `Sentry.AspNetCore` and `Sentry.Maui` (#4193)

Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: James Crosswell <[email protected]>
Co-authored-by: Sentry Github Bot <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants