fix(rate-limits): Consistently emit rate limit outcomes for attachments #5301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/fix-attachment-limits-dependent-category
branch
from
3df3edb to
332e2af
Compare
Dav1dde
force-pushed
the
dav1d/fix-attachment-limits-dependent-category
branch
from
332e2af to
c8aea2e
Compare
loewenheim
approved these changes
Oct 28, 2025
jjbayer
approved these changes
Oct 28, 2025
jjbayer
pushed a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outcomes in the
attachmentcategory were not consistently applied toattachment_item, but more importantly rate limits in theattachment_itemscategory did not generate outcomes in theattachmentcategory.