Skip to content

Fix unexpected /app shadowing in compose.yaml (#7433) #7434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix unexpected /app shadowing in compose.yaml (#7433) #7434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ x-redash-service: &redash-service
context: .
args:
skip_frontend_build: "true" # set to empty string to build
volumes:
- .:/app
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bindmount is not a mistake, it is required for live-reload in a dev environment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eradman what about using separate path for frontend artifacts like /www/html here and here to avoid shadowing by mounted volume? Let me know if you accept this approach

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to understand #7433 better. What is the reason for setting skip_frontend_build: ""?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid skipping of frontend build = force frontend building. Since there is no frontend after cloning the repo, the user needs to build it first.

This is suggested in compose.yml comments

    args:
      skip_frontend_build: "true"  # set to empty string to build

BTW finding this trick was another troubleshooting journey on the way to make it run )

env_file:
- .env
x-redash-environment: &redash-environment
Expand Down