Skip to content

Conversation

@eradman
Copy link
Collaborator

@eradman eradman commented May 1, 2025

What type of PR is this?

  • Bug Fix

Description

Preview images works for personal repositories, but we missed another variable when publishing official images:

  #34 [auth] arikfr/redash:pull,push token for registry-1.docker.io
  #34 DONE 0.0s
  #33 exporting to image
  #33 pushing layers 15.5s done
  #33 pushing manifest for docker.io/arikfr/redash
  #33 pushing manifest for docker.io/arikfr/redash 1.6s done
  #33 ...
  #35 [auth] arikfr/preview:pull,push token for registry-1.docker.io
  #35 DONE 0.0s

https://github.com/getredash/redash/actions/runs/14776025489/job/41484408477

How is this tested?

  • Manually

Tested on personal repository (https://hub.docker.com/r/eradman/redash/)

Preview images work for personal repositories, but we missed another variable
when publishing official images:

  getredash#34 [auth] arikfr/redash:pull,push token for registry-1.docker.io
  getredash#34 DONE 0.0s
  getredash#33 exporting to image
  getredash#33 pushing layers 15.5s done
  getredash#33 pushing manifest for docker.io/arikfr/redash
  getredash#33 pushing manifest for docker.io/arikfr/redash 1.6s done
  getredash#33 ...
  getredash#35 [auth] arikfr/preview:pull,push token for registry-1.docker.io
  getredash#35 DONE 0.0s
@eradman eradman requested a review from arikfr May 1, 2025 15:39
@arikfr arikfr enabled auto-merge (squash) May 5, 2025 06:18
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arikfr arikfr merged commit 2f35ceb into getredash:master May 5, 2025
11 checks passed
@eradman eradman deleted the docker-push branch May 5, 2025 13:15
@eradman
Copy link
Collaborator Author

eradman commented May 5, 2025

Thank you for merging! I kicked off the Preview image action and it succeeded
https://hub.docker.com/r/redash/preview/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants