openapi3: replace bigfloat with decimal128 to fix rounding errors during validation #1068
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revolyssup
commented
May 8, 2025
| @@ -1643,7 +1644,10 @@ func (schema *Schema) visitJSONNumber(settings *schemaValidationSettings, value | |||
| if v := schema.MultipleOf; v != nil { | |||
| // "A numeric instance is valid only if division by this keyword's | |||
| // value results in an integer." | |||
| if bigFloat := big.NewFloat(value / *v); !bigFloat.IsInt() { | |||
| numParsed, _ := decimal128.Parse(fmt.Sprintf("%.10f", value)) | |||
There was a problem hiding this comment.
Going higher, example %.15f here will break test case like 19628.87
As using %.15f turns this to 19628.869999999989.... causing non zero remainder later. I think it's okay to lose a little precision here to have precision in the remainder.
fenollp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #817
Following the suggestion here #817 (comment)