Skip to content

archive_open: Return LIBMPQ_ERROR_EXIST on ENOENT #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

archive_open: Return LIBMPQ_ERROR_EXIST on ENOENT #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libmpq/mpq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "common.h"

/* generic includes. */
#include <errno.h>
#include <fcntl.h>
#include <stdlib.h>
#include <string.h>
Expand Down Expand Up @@ -91,10 +92,11 @@ int32_t libmpq__archive_open(mpq_archive_s **mpq_archive, const char *mpq_filena
}

/* check if file exists and is readable */
errno = 0;
if (((*mpq_archive)->fp = fopen(mpq_filename, "rb")) == NULL) {

/* file could not be opened. */
result = LIBMPQ_ERROR_OPEN;
result = errno == ENOENT ? LIBMPQ_ERROR_EXIST : LIBMPQ_ERROR_OPEN;
goto error;
}

Expand Down
2 changes: 1 addition & 1 deletion libmpq/mpq.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ extern "C" {
#define LIBMPQ_ERROR_FORMAT -7 /* format errror. */
#define LIBMPQ_ERROR_NOT_INITIALIZED -8 /* libmpq__init() wasn't called. */
#define LIBMPQ_ERROR_SIZE -9 /* buffer size is to small. */
#define LIBMPQ_ERROR_EXIST -10 /* file or block does not exist in archive. */
#define LIBMPQ_ERROR_EXIST -10 /* archive does not exist, or file or block does not exist in archive. */
#define LIBMPQ_ERROR_DECRYPT -11 /* we don't know the decryption seed. */
#define LIBMPQ_ERROR_UNPACK -12 /* error on unpacking file. */

Expand Down