Update coreprofiler db #7341
Update coreprofiler db #7341
Conversation
|
This PR close this one : #7331 |
|
Hi @SaimMomin12, I see that you rerun test, any idea why it fails ? The error doesn't seem to come from the tool. Is it a wrapper or a galaxy error ? |
No, unfortunately we are experiencing some CI issues lately. Nonetheless, we re-trigger the failed workflow manually :) |
|
I see the test timed out after 1800.25 seconds and failed. Let me loop in @bernt-matthias |
|
1800s is the max runtime of a test allowed in our CI. any way to speed things up? |
I'm not sure it's possible to speed things up. The three tests involve three different databases, and the last one, which concerns Enterobase, only has two possible values, and the one that was tested is the smallest. Maybe we can delete this one? The parameters used are the same as for the other databases. |
|
Currently, we have no way of speeding things up, so we can suggest removing this test, or perhaps it is possible to extend run time for CI ? |
...rs/data_manager_build_coreprofiler/data_manager/data_manager_build_coreprofiler_download.xml
Outdated
Show resolved
Hide resolved
I remove the test that fail because of time limit, I use bash variables for token and secrets parameters (but I'm not sure I wrote or use them well), and I added a conditional to distinguish token and non token generated databases. |
| -k ${CONSUMER_TOKEN} | ||
| -ks ${CONSUMER_SECRET} | ||
| -a ${ACCESS_TOKEN} | ||
| -as ${ACCESS_SECRET} |
There was a problem hiding this comment.
Those are not bash variables. Should be "$CONSUMER_TOKEN". I would make them less generic, maybe "$COREPROFILER_CONSUMER_TOKEN".
Might be cool to add a bash if statement checking if they are set if needed and output a helpful error message if needed.
There was a problem hiding this comment.
Thanks for the feedback, I'll make the necessary changes.
3 participants
FOR CONTRIBUTOR:
Closes: #7331