This repository was archived by the owner on Oct 19, 2024. It is now read-only.
  
  
  - 
                Notifications
    
You must be signed in to change notification settings  - Fork 789
 
Feat/add withdrawals root #2348
          
     Merged
      
      
            gakonst
  merged 7 commits into
  gakonst:master
from
merklefruit:feat/add-withdrawals-root
  
      
      
   
  Apr 24, 2023 
      
    
                
     Merged
            
            Feat/add withdrawals root #2348
                    gakonst
  merged 7 commits into
  gakonst:master
from
merklefruit:feat/add-withdrawals-root
  
      
      
   
  Apr 24, 2023 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    mattsse
  
              
              suggested changes
              
                  
                    Apr 13, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we're at it, let's also add the withdrawals field as well
| 
           Added basic support for   | 
    
              
                    mattsse
  
              
              suggested changes
              
                  
                    Apr 13, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there
              
                    mattsse
  
              
              approved these changes
              
                  
                    Apr 13, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
              
                    gakonst
  
              
              approved these changes
              
                  
                    Apr 24, 2023 
                  
              
              
            
            
| 
               | 
          ||
| /// A validator withdrawal from the consensus layer. | ||
| /// See EIP-4895: Beacon chain push withdrawals as operations. | ||
| #[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit can derive
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Motivation
Adds support for EIP-4895 and closes #2344
Solution
Add
withdrawals_rootproperty to theBlockstruct type.PR Checklist