[WIP] Fix issues with destructuring support #1587
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the issue where intermediate destructured properties were being inserted in the wrong order. The problem was in the
findExpectedIndexfunction insrc/rules/requireParam.js.The Issue
When documenting
function quux ({ foo, bar: { baz }})with:The missing
root0.barwas being inserted afterroot0.bar.bazinstead of before it.The Fix
Changed
findExpectedIndexto use the flattened parameter list correctly:functionParameterNames.slice(indexAtFunctionParams)which used the unflattened structureflattenedRoots.slice(indexAtFunctionParams + 1)which uses the correct flattened orderThe fix now correctly inserts
root0.barbetweenroot0.fooandroot0.bar.baz.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.