`imports-as-dependencies`: package with `exports` instead of `types`

[regseb]

Expected behavior

imports-as-dependencies supports types defined in the exports property.

Actual behavior

imports-as-dependencies reports: import points to package which is not found in dependencies. Because the rule only looks at the types and typings properties. importsAsDependencies.js#L106

Files

package.json

{
  "name": "testcase",
  "dependencies": {
    "eslint": "8.42.0",
    "eslint-plugin-jsdoc": "46.2.4",
    "playwright": "1.34.3"
  },
  "eslintConfig": {
    "plugins": [
      "jsdoc"
    ],
    "rules": {
      "jsdoc/imports-as-dependencies": "error"
    }
  }
}

index.js

/**
 * @type {import("playwright")}
 */
var playwright;

Environment

• Node version: 18.16.0
• ESLint version 8.42.0
• eslint-plugin-jsdoc version: 46.2.4

Additional info

There's a similar problem with ESLint rules checking imports, as they only look at the main property:

• no-missing-imports does not support "exports" in package.json mysticatea/eslint-plugin-node#255
• node/no-missing-import false positive on chalk v5 mysticatea/eslint-plugin-node#314
• no-unresolved is not aware of exports definition in package.json import-js/eslint-plugin-import#1810
• Rule import/no-unresolved raise false positive when there is no main field in the package.json import-js/eslint-plugin-import#2132

[brettz9]

I've filed lukeed/resolve.exports#30 so we can hopefully reuse that package's mechanism for navigating exports (which is not trivial).

[brettz9]

@regseb : If you care to fork the project, I'd be happy to use it. Doesn't look like it is going to be maintained at this rate.

[regseb]

I think the resolve-import library can also solve the problem.

import { resolveImport } from 'resolve-import'

// packages resolved according to their exports, main, etc.
// eg: URL(file:///path/node_modules/pkg/dist/mjs/index.js)
console.log(await resolveImport('pkg', '/path/to/y.js'))

But like resolve.exports, the default condition is always present.

Interface ResolveImportOpts

• conditions: string[] The list of conditions to match on. 'default' is always accepted. Defaults to ['import', 'node'].

An issue would have to be opened?

[brettz9]

Sounds like it, yes...

[regseb]

The pull request has been merged (isaacs/resolve-import@6f0c591) and the new version 2.1.0 of resolve-import has been released.

import { resolveImport } from 'resolve-import'

// packages resolved according to their exports, main, etc.
// eg: URL(file:///path/node_modules/pkg/dist/mjs/index.js)
console.log(await resolveImport('pkg', '/path/to/y.js', { conditions: ['!default', 'types'] }));