Skip to content

Conversation

voravor
Copy link

@voravor voravor commented Jun 1, 2015

Allow DynamoDB Local endpoints to be passed into AWS.config.update.

Allow DynamoDB Local endpoints to be passed into AWS.config.update.
@devinivy
Copy link
Collaborator

devinivy commented Jun 1, 2015

If your new local endpoint option is not set, will trying to set it here break existing users' implementations? Also, do you mind lowercasing endPoint to endpoint for consistency?

@voravor
Copy link
Author

voravor commented Jun 2, 2015

Tested adapter leaving out "endPoint" from the adapter settings in connections.js. Adapter still connected to dynamodb correctly, no errors. Connection defaults to whatever your region/key/secret permits you access to. In other words, it connected me with my correct dynamodb table at dynamodb.us-east-1.amazonaws.com. Add "endPoint" back in (with a dynamodb local running) and it connected to dynamodb-local correctly.

BTW, the only reason I set it as endPoint is that sails-dynamodb uses endPoint. I'd prefer lowercase because Vogels/AWS-SDK uses "endpoint" (no camel case). Do you still want me to lowercase it?

@devinivy
Copy link
Collaborator

devinivy commented Jun 2, 2015

Thanks– looks good. I see now that some old code uses "endPoint"– we'll make a breaking change some day soon to fix that, or we'll create an alias config option. For now, all's well.... Merging!

devinivy added a commit that referenced this pull request Jun 2, 2015
@devinivy devinivy merged commit b799577 into gadelkareem:master Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants