Skip to content

Conversation

@IanWitham
Copy link
Contributor

Various layout changes for a more modern and coherent look.

My changes can be previewed here: https://ianwitham.github.io/fsharp.org/

I was originally trying to just fix the nav menu on mobile, which I have also done. Main changes are:

  • Dump bootstrap 3 and upgrade styles with Tailwind CSS
  • Use "official" font Rajdhani for headings
  • integrate HTMX and AlpineJS for improved interactivity
  • add a search to the testimonials page (Lunr.js)
  • and remove the news feed as per Change or remove news feed #942
  • Implement dark mode, just because.
  • Migrated testimonials to a collection (i.e. each in their own md file, in the _testimonials folder)

Note that if merging this, it may be necessary to go to repo settings and change Pages -> Build and Deploy source from "Deploy from Branch" to "Github Actions". This is because tailwind/postcss integration requires a more sophisticated build than is supported by "classic" github pages build.

I fully expect such a major change to generate some discussion before merging.

Upgrade to tailwind 4

Integrate HTMX

Integrate alpineJS

Add search to testimonial page

Remove news feed
@dsyme
Copy link
Contributor

dsyme commented Mar 10, 2025

The changes look great!

I'd be in favour of a font change TBH - I'm no fan of the current font

@vzarytovskii WDYT?

@vzarytovskii
Copy link
Collaborator

Yeah, agree on the font, it renders a bit weird.

@dsyme
Copy link
Contributor

dsyme commented Mar 10, 2025

Looking around I see some dead links

  • https://foundation.fsharp.org/member_roster looks non-responsive
  • The FSSF material in general is indicative of the moribund state of the foundation (basically it doesn't seem to be active, and it looks this site should gradually be changed to be just an F# community site rather than the FSSF site per se - though still totally in lone with the mission statement of the foundation which should still be our guiding light)
  • The X.com links should generally be removed at the community have pretty much moved off that platform
  • The "user groups" and "speakers program" look out of date and can be dropped
  • https://fsharp.github.io/FSharp.Compiler.Service/ is 404 and should point to https://fsharp.github.io/fsharp-compiler-docs/fcs/
  • Visual Studio for Max is no longer a thing and should be removed as a link

I think we should drop the "unaffiliated" CSS tags because the FSSF affiliation is no longer as central here.

There will be more links to clean-up too, this is a start

@dsyme
Copy link
Contributor

dsyme commented Mar 10, 2025

Regarding the actual code changes - it's a big change but looking at the site it seems to be working fine. I don't know enough about the different new technologies to comment much more but it seems fine to progress with this and move on - we can always revert if really necessary

@vzarytovskii Do you agree?

@vzarytovskii
Copy link
Collaborator

Regarding the actual code changes - it's a big change but looking at the site it seems to be working fine. I don't know enough about the different new technologies to comment much more but it seems fine to progress with this and move on - we can always revert if really necessary

@vzarytovskii Do you agree?

Yeah, agree.

@dsyme
Copy link
Contributor

dsyme commented Mar 10, 2025

@IanWitham I will merge, thanks for the great work and we'd love to see it continue!

@dsyme dsyme merged commit c68cb36 into fsharp:gh-pages Mar 10, 2025
@dsyme
Copy link
Contributor

dsyme commented Mar 10, 2025

@IanWitham There are two CI jobs running, is this as expected?

image

@IanWitham
Copy link
Contributor Author

@dsyme no, that's unexpected. Did you make the following change?

Note that if merging this, it may be necessary to go to repo settings and change Pages -> Build and Deploy source from "Deploy from Branch" to "Github Actions"

@IanWitham
Copy link
Contributor Author

Thanks for the other feedback too. Happy to get rid of the x.com link with extreme prejudice

@dsyme
Copy link
Contributor

dsyme commented Mar 10, 2025

@IanWitham Got it, set that now, is it OK now?

@dsyme
Copy link
Contributor

dsyme commented Mar 10, 2025

@IanWitham looking forward to your next PR then, enjoy the deletion!

@IanWitham
Copy link
Contributor Author

Can't see the repo settings, but we'll find out when the next commit happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants