Find asset catalogs automatically #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge in latest.
…et-catalogs # Conflicts: # Classes/main.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I finally had a little time to complete a project which I was wanting to do for a while, supporting multiple asset catalogs and finding the asset catalogs automatically within the source. So now you can just add
${PODS_ROOT}/AssetChecker/runinto your Build Phases and it should just work.
I also changed the error output so that it will link to the file where the asset is missing instead of the asset catalog. I think this is a bit more helpful.
I also added some images for testing in the sample project, as well as some instances of errors and warnings. The sample project throws the correct AssetChecker errors and warnings.
Hopefully you can find some time to review these additions. This was a pretty large refactoring of the script file. I've tested it in two of my projects.