Refactor to remove AuthenticatedContext and pass client to query functions #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're removing the AuthenticatedContext pattern from the SDK since it's unidiomatic in Go to extend the context, save it as an attribute and use it to store data across multiple requests. We were previously using the AuthenticatedContext to save the request token across requests. It meant we didn't need to get the token freshly on every request. Instead we now store the token in the client and have users pass the same client to every request.
This will be a breaking change and will change the function signature of SDK functions.
This PR also creates a
CONTRIBUTING.mdfile.Summary of changes
fixes FRA-6031