fix(forge): v1.3 do not throw if etherscan api key set and unknown chain #11444
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
grandizzy
changed the title
zerosnacks
changed the title
zerosnacks
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Makes sense, for other reviewers: reverts problematic code introduced in https://github.com/foundry-rs/foundry/pull/11194/files#diff-0f348074359029c2930eb72b52f482c2e0f4495dc61b95bc919f155a8d2fd82cR1437-R1444, retains improved error descriptions
|
Tested w/ Verifies correctly on Blockscout |
yash-atreya
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
forge verify-contractfails with perplexing error message for unrecognized chains #11186 in v1.4.0, throwing the err is just breaking other verifiers when ETHERSCAN_API_KEY setPR Checklist