feat(forge): loosen tx gas limit restrictions ahead of Osaka + make enforceable w/ --enable-tx-gas-limit
#11427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
--enable-tx-gas-limit
zerosnacks
commented
Aug 26, 2025
zerosnacks
commented
Aug 26, 2025
| @@ -265,6 +265,7 @@ impl CallArgs { | |||
|
|
|||
| // modify settings that usually set in eth_call | |||
| env.evm_env.cfg_env.disable_block_gas_limit = true; | |||
| env.evm_env.cfg_env.tx_gas_limit_cap = Some(u64::MAX); | |||
There was a problem hiding this comment.
this makes sense to me, do not enforce tx gas limit when simulating the behavior of an eth_call
zerosnacks
commented
Aug 26, 2025
| @@ -1558,6 +1559,7 @@ impl Backend { | |||
| // we want to disable this in eth_call, since this is common practice used by other node | |||
| // impls and providers <https://github.com/foundry-rs/foundry/issues/4388> | |||
| env.evm_env.cfg_env.disable_block_gas_limit = true; | |||
| env.evm_env.cfg_env.tx_gas_limit_cap = Some(u64::MAX); | |||
There was a problem hiding this comment.
same here, makes sense to avoid enforcing a tx gas limit cap here
6 tasks
zerosnacks
commented
Aug 27, 2025
| } | ||
|
|
||
| // check that we comply with the transaction's gas limit as imposed by Osaka (EIP-7825) | ||
| if env.evm_env.cfg_env.tx_gas_limit_cap.is_none() |
There was a problem hiding this comment.
spec's before Osaka have this set to Some(U64::max) by default
it is debatable if it is really necessary to catch it here but could give user a richer error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #11348
Solution
Enforcing of tx gas limit is disabled by default as this is what users would expect, allow users to enforce the tx gas limit imposed by Osaka (EIP-7825). If there are further changes that change this tx gas limit we can make expand this to be EVM version specific.
Adds clarifying alias to
block_gas_limit/disable_block_gas_limitto beblockspecific, retaining original alias for backwards compatibilityBreaking changes
Renamed
TransactionExecutionOutcome::Exhausted=>TransactionExecutionOutcome::BlockGasExhaustedfor clarity, expecting this to have no impact on regular usersPR Checklist