fix: added ripple effect for voice commands #2173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhavnaharitsa
changed the title
| @@ -0,0 +1,12 @@ | |||
| <selector xmlns:android="http://schemas.android.com/apk/res/android"> | |||
| @@ -0,0 +1,7 @@ | |||
| <ripple xmlns:android="http://schemas.android.com/apk/res/android" | |||
|
Why are you closing PRs and creating new ones? |
|
@iamareebjamal I have removed unnecessaries, but still, the circleci is failing. I have checked the possible solutions. |
iamareebjamal
approved these changes
Apr 16, 2019
mkmar01
approved these changes
Apr 16, 2019
arundhatigupta
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2158
Changes: Added ripple effect into the set of commands.
It's just a replica of the earlier closed issue #2160
Unfortunately, I had to close the pull request due to system crash.