fix: Use event ID in favorite remove API call #2346

ranjsa · 2019-09-17T08:25:45Z

Changes: [Before - for removing favourite event it was passing favoriteEventId so that it was showing error "Object not found"
After - In open-event-api-dev.herokuapp for deleteing a favourite event it is expecting event.id , So I change favouriteEventId to event.id And now it is able to remove favourite events successfully. ]

Screenshots for the change:

liveHarshit · 2019-09-17T08:29:00Z

app/build.gradle

    aaptOptions {
        cruncherEnabled = false
    }
+    buildToolsVersion = '29.0.2'


That got changed automatically
when i was setting up the project on my system .
Should i remove it ?

liveHarshit

Please revert unnecessary changes

anhanh11001

Squash your commits as well. Try to keep 1 commit/PR. Follow Harshit request and rest is good

liveHarshit · 2019-09-17T09:08:59Z

@ranjsa Build is failing. Always check for spotless before commit using ./gradlew spotlessCheck for check and ./gradlew spotlessApply to fix.

iamareebjamal · 2019-09-17T10:15:40Z

Please see titles of other PRs and follow same semantics

See the body

ranjsa · 2019-09-17T11:07:17Z

@anhanh11001

Squash your commits as well. Try to keep 1 commit/PR. Follow Harshit request and rest is good
Done 👍

@ranjsa Build is failing. Always check for spotless before commit using ./gradlew spotlessCheck for check and ./gradlew spotlessApply to fix.
@liveHarshit
Done 👍

liveHarshit

Okay, so now you removed the whole manifest file.

liveHarshit · 2019-09-17T11:12:01Z

Please see titles of other PRs and follow same semantics

See the body

@ranjsa

ranjsa · 2019-09-17T11:36:21Z

Okay, so now you removed the whole manifest file.

@liveHarshit 😅 No , Sorry actually there was a conflict and by mistake i deleted that file but i put that back again and resolved the conflicts ...
is it OK now ?

iamareebjamal · 2019-09-17T11:39:56Z

Have you read this? #2346 (comment)

Has been posted 2 times now

iamareebjamal · 2019-09-17T11:40:29Z

app/src/main/AndroidManifest.xml

-                <data
-                    android:pathPrefix="/reset-password"/>
-                <data
-                    android:pathPrefix="/email"/>


This just got added up from my repository unknowingly So i removed it .

This just got added up from my repository unknowingly So i removed it .

I wish magic existed in real world, but nothing gets added unknowingly

ranjsa · 2019-09-17T11:43:47Z

Have you read this? #2346 (comment)

Has been posted 2 times now
@iamareebjamal
Yes i saw that i was just changing the title

iamareebjamal · 2019-09-17T11:54:20Z

Still not correct and tests are failing

ranjsa · 2019-09-17T12:03:36Z

Still not correct

@iamareebjamal Should I remove everything from body except gif file , Will that be fine ?

nikit19

Try rebasing and squashing your commits

ranjsa · 2019-09-17T12:10:12Z

Try rebasing and squashing your commits

@nikit19 OK doing it

liveHarshit · 2019-09-17T12:11:44Z

app/src/main/AndroidManifest.xml

+                    android:pathPrefix="/reset-password"/>
+                <data
+                    android:pathPrefix="/email"/>
+


Do not commit this file at all.

Actually before sending PR I pulled all the changes from upstream , So thats why it got added up
What should i do Now ?

liveHarshit · 2019-09-17T12:11:50Z

app/src/main/java/org/fossasia/openevent/general/event/EventService.kt


    fun addFavorite(favoriteEvent: FavoriteEvent, event: Event) =
        favoriteEventApi.addFavorite(favoriteEvent).map {
+


Ok I will remove that extra space

iamareebjamal · 2019-09-17T12:14:54Z

Should I remove everything from body except gif file , Will that be fine ?

Your title is not according to standards. Please carefully look at other titles

iamareebjamal · 2019-09-17T12:17:36Z

Never make PRs from development branch. Always create a new branch for each PR

liveHarshit

Always follow the commit guidelines: http://chris.beams.io/posts/git-commit/

stale

ranjsa mentioned this pull request Sep 17, 2019

Not able to remove favorite events #2183

Closed

liveHarshit reviewed Sep 17, 2019

View reviewed changes

liveHarshit suggested changes Sep 17, 2019

View reviewed changes

anhanh11001 reviewed Sep 17, 2019

View reviewed changes

ranjsa force-pushed the development branch from d7ddb6a to 96dc42b Compare September 17, 2019 11:04

liveHarshit suggested changes Sep 17, 2019

View reviewed changes

ranjsa force-pushed the development branch from c9d8442 to 96dc42b Compare September 17, 2019 11:22

iamareebjamal previously requested changes Sep 17, 2019

View reviewed changes

ranjsa changed the title ~~Fixing Issue #2183~~ Fix: Not able to remove favorite events Sep 17, 2019

ranjsa force-pushed the development branch from b7712bb to 96dc42b Compare September 17, 2019 12:01

nikit19 reviewed Sep 17, 2019

View reviewed changes

liveHarshit reviewed Sep 17, 2019

View reviewed changes

Fixed isssue

7c121a9

ranjsa changed the title ~~Fix: Not able to remove favorite events~~ fix: Not able to remove favorite events Sep 17, 2019

auto-label bot added the fix label Sep 17, 2019

ranjsa force-pushed the development branch from e5e814a to 7c121a9 Compare September 17, 2019 13:09

liveHarshit approved these changes Sep 17, 2019

View reviewed changes

iamareebjamal changed the title ~~fix: Not able to remove favorite events~~ fix: Use event ID in favorite remove API call Sep 17, 2019

iamareebjamal merged commit 97b6788 into fossasia:development Sep 17, 2019

liveHarshit mentioned this pull request Sep 24, 2019

fix: pending ticket redirected to payment page. #2356

Open


		fun addFavorite(favoriteEvent: FavoriteEvent, event: Event) =
		favoriteEventApi.addFavorite(favoriteEvent).map {

fix: Use event ID in favorite remove API call #2346

fix: Use event ID in favorite remove API call #2346

Uh oh!

Conversation

ranjsa commented Sep 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liveHarshit left a comment

Choose a reason for hiding this comment

Uh oh!

anhanh11001 left a comment

Choose a reason for hiding this comment

Uh oh!

liveHarshit commented Sep 17, 2019

Uh oh!

iamareebjamal commented Sep 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ranjsa commented Sep 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liveHarshit left a comment

Choose a reason for hiding this comment

Uh oh!

liveHarshit commented Sep 17, 2019

Uh oh!

ranjsa commented Sep 17, 2019

Uh oh!

iamareebjamal commented Sep 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Sep 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ranjsa commented Sep 17, 2019

Uh oh!

iamareebjamal commented Sep 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ranjsa commented Sep 17, 2019

Uh oh!

nikit19 left a comment

Choose a reason for hiding this comment

Uh oh!

ranjsa commented Sep 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Sep 17, 2019

Uh oh!

iamareebjamal commented Sep 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liveHarshit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

ranjsa commented Sep 17, 2019 •

edited

Loading

iamareebjamal commented Sep 17, 2019 •

edited

Loading

ranjsa commented Sep 17, 2019 •

edited

Loading

iamareebjamal Sep 17, 2019 •

edited

Loading

iamareebjamal commented Sep 17, 2019 •

edited

Loading

iamareebjamal commented Sep 17, 2019 •

edited

Loading

liveHarshit left a comment •

edited

Loading