Support for `neshClassicCache`

[harry-gocity]

Is neshClassicCache a function you are planning to support?

We have an app with a mix of app and pages router. In pages router, I'd like to use an equivalent of neshClassicCache to wrap async fetch calls in getServerSideProps. It doesn't look like this is supported currently in this library.

[AyronK]

As far as I understand neshClassicCashe is just an extra functionality coming from neshca and should be working just fine in the original package with Next 15. I don't see any compatibility issues in https://github.com/caching-tools/next-shared-cache/blob/0da50b6745a32098f97802fc74deb44962e669d4/packages/cache-handler/src/functions/nesh-classic-cache.ts thus I recommend just using the original package to resolve neshClassicCashe and combine it with CacheHandler from this repository.

If you spot compatibility issues I'll be happy to help, but I don't see any reason to just copy-paste the code just for the sake of availability, it adds complexity and maintenance and this package was born to address compatibility issues rather than replace the original package completely (at least for now, we'll see if the original package is really dead or not and what the community does).

[harry-gocity]

I recommend just using the original package to resolve neshClassicCashe and combine it with CacheHandler from this repository.

Thanks very much - this is perfect!

[harry-gocity]

Hi @AyronK I've moved our project over to use this library and everything is looking great. I may have some follow up questions, is discussions the best place for me to ask those?

For this issue - there is unfortunately a compatibility issue using nextClassicCache with Next 15.

It looks like staticGenerationAsyncStorage got renamed to workAsyncStorage in vercel/next.js#70721 and then moved in vercel/next.js#70934.

I've patched the neshca package to point to next/dist/server/app-render/work-async-storage.external.js instead of next/dist/client/components/static-generation-async-storage.external.js and it looks like it's working ok so far in testing - a wrapped fetch call is getting cached in Redis.

[AyronK]

@harry-gocity oh I missed the comment as the issue was closed already. I see you found compatibility issues with that method so I think it's a good reason to move that code along. Would you consider adding a PR to this package if you had a chance to fix it already? If you're still stuck give me a nudge and I can take a look as well, but I'm not quite familiar with this feature.

[harry-gocity]

@AyronK I'm about to go on 10 days holiday, but am happy to do so when I return to work. The fix is straightforward with PNPM patches - it ends up just being a small diff updating imports.

[AyronK]

@harry-gocity thank you for you work. I published 2.3.0 and updated README.