Have use_allocate_node also check alignment #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the segregator, it checks the size of the allocation. However, some allocators (I'm looking at you, memory_pool_collection_allocator) throw if the requested alignment is too big. However, the segregator could have a fallback allocator that supports the larger alignment. If we just made a hard change, this could break existing code. Thus, another parameter can be passed to the threshold constructor that can enable alignment checking. It is a strong type so there should be no inconvenient implicit conversions and in order to get the new behavior, it will have to be explicitly requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the segregator, it checks the size of the allocation. However, some allocators (I'm looking at you,
memory_pool_collection_allocator) throw if the requested alignment is too big. However, the segregator could have a fallback allocator that supports the larger alignment.
If we just made a hard change, this could break existing code. Thus, another parameter can be passed to the threshold constructor that can enable alignment checking. It is a strong type so there should be no inconvenient implicit conversions and in order to get the new behavior, it will have to be explicitly requested.