Add RISC-V platform support in discoapi #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1 Add support for RISC-V 64-bit architecture in discoapi. * Add `riscv64` architecture to `ARCHITECTURE_MAP` in `src/main/java/io/foojay/api/distribution/Temurin.java`. * Update `getUrlForAvailablePkgs` method to include `riscv64` in `src/main/java/io/foojay/api/distribution/Temurin.java`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/discoapi/issues/1?shareId=XXXX-XXXX-XXXX-XXXX).
|
The RiscV64 pkgs from Temurin are already available...please check for example this: https://api.foojay.io/disco/v3.0/packages?distribution=temurin&latest=available&release_status=ga&architecture=riscv64&jdk_version=23 |
|
Thank you for the feedback. I initially thought my proposed changes would resolve this SDKMan! issue. I now understand that adding I apologize for the confusion. I'm still learning how the system handles architectures without explicit definitions. Could you help me understand this better? |
|
SDKMan gets all OpenJDK and GraalVM distributions from discoapi. But that doesn’t mean they provide all architectures etc. that disco offers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue sdkman/sdkman-cli#1321, I propose to add the
RISCV64architecture to discoapi.riscv64architecture toARCHITECTURE_MAPinsrc/main/java/io/foojay/api/distribution/Temurin.java.getUrlForAvailablePkgsmethod to includeriscv64insrc/main/java/io/foojay/api/distribution/Temurin.java.Summary
RISCV64architecture in the architecture mapping, enhancing the capability to handle a broader range of architectures for package requests.Walkthrough
The changes introduced in this pull request involve the addition of a new architecture,
RISCV64, to theARCHITECTURE_MAPwithin theTemurinclass. This update includes mapping theRISCV64architecture to the string representation "riscv64", allowing theTemurinclass to support RISC-V 64-bit architecture in URL parameters. No other modifications to logic or error handling were made, ensuring that the existing functionality of the class remains unchanged.Changes
RISCV64toARCHITECTURE_MAP, mapping to "riscv64".