Skip to content

Fix scrollthumb shrinking when vertical padding provided #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix scrollthumb shrinking when vertical padding provided #54

wants to merge 1 commit into from

Conversation

@emvaized
Copy link

@emvaized emvaized commented Dec 9, 2021 •
edited
Loading

When vertical padding is provided to the scrollbar, scroll thumb shrinks on reaching the end of scroll. This happens because barMaxScrollExtent doesn't count vertical padding provided to the widget.

My fix changes this behavior by subtracting widget.padding?.vertical in barMaxScrollExtent.

@emvaized
Fix scrollthumb shrinking when vertical padding provided
242c731 
When vertical padding is provided to the scrollbar, scroll thumb shrinks on reaching end of scroll. This happens because `barMaxScrollExtent` doesn't count vertical padding provided to widget.
My fix changes this behavior by subtracting `widget.padding?.vertical` from `barMaxScrollExtent`.
@emvaized
Copy link
Author

emvaized commented Dec 9, 2021 •
edited
Loading

Demonstration with:

DraggableScrollbar.arrows(
        padding: EdgeInsets.only(bottom: 100),
        child: ListView(
        padding: EdgeInsets.only(bottom: 100),
        ...

Before:
before (1)

After:
after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@emvaized