[go_router] Add state restoration topic to documentation #9867
+660
−343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chunhtai Does the premise and approach of this PR make sense to you? |
|
I will take a closer look sometimes tmr |
LukasMirbt
force-pushed
the
go-router/state-restoration-docs
branch
from
ea287b9 to
5284fa6
Compare
github-actions
bot
added
p: shared_preferences
and removed
p: shared_preferences
labels
LukasMirbt
force-pushed
the
go-router/state-restoration-docs
branch
from
3074d34 to
840ebd8
Compare
LukasMirbt
changed the title
LukasMirbt
force-pushed
the
go-router/state-restoration-docs
branch
6 times, most recently
from
1a02f3c to
4f4a01d
Compare
LukasMirbt
force-pushed
the
go-router/state-restoration-docs
branch
from
4f4a01d to
a88e267
Compare
chunhtai
approved these changes
Aug 22, 2025
Awesome! 🎉 Can it be auto-submitted or does it need a second review? |
LukasMirbt
force-pushed
the
go-router/state-restoration-docs
branch
3 times, most recently
from
fd36961 to
6075554
Compare
LukasMirbt
changed the title
LukasMirbt
force-pushed
the
go-router/state-restoration-docs
branch
from
6075554 to
d876cfb
Compare
|
@chunhtai Should @hannah-hyj be requested for review on this PR? |
LukasMirbt
force-pushed
the
go-router/state-restoration-docs
branch
from
d876cfb to
57d0c64
Compare
|
I think we need two reviewer in order to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring state restoration with
go_routeris quite tricky and there are several open issues related to state restoration.This PR adds a section in the docs which clearly documents
go_routerstate restoration as well as tests that verify the documented behavior.Related issues: flutter/flutter#129165, flutter/flutter#117683
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3