Skip to content

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Aug 19, 2025

Implements NV21 support for image streaming.

Also bumps the CameraX version to 1.5.0-rc01! To do this, I needed to (1) bump the minimum SDK version to 23 and (2) modify a couple of unrelated tests.

Fixes flutter/flutter#145961.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@camsim99 camsim99 changed the title [camera_android_camerax Support NV21. [camera_android_camerax] Support NV21 Aug 25, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that the diff here is a bit funky....it might be easier to look at the file itself and search for the tests that I modified there. I really only:

  1. Modified tests that tested logic previously in createCamera that I moved to initializeCamers
  2. Added createCamera and initializeCamera properly set filter for resolution preset for non-video capture use cases and initializeCamera sets camera state observer as expected.

@camsim99 camsim99 marked this pull request as ready for review August 26, 2025 18:58
@camsim99 camsim99 requested review from jesswrd and a team August 26, 2025 18:59
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 27, 2025
@auto-submit auto-submit bot merged commit c905585 into flutter:main Aug 27, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[camera_android_camerax] Cannot set imageFormatGroup to ImageFormatGroup.nv21
2 participants