Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,14 @@
import 'dart:js_interop';
import 'dart:js_interop_unsafe';
import 'dart:typed_data';
import 'dart:ui' show SemanticsFlag;
import 'dart:ui_web' as ui_web;

import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart' show SemanticsNode;
import 'package:flutter/semantics.dart'
show DebugSemanticsDumpOrder, SemanticsData;
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';
import 'package:url_launcher_platform_interface/link.dart';
Expand Down Expand Up @@ -181,6 +186,56 @@ void main() {
maxScrolls: 1000,
);
});

testWidgets(
'excludeSemantics: true ensures clean link semantics without conflicts',
(WidgetTester tester) async {
await tester.pumpWidget(MaterialApp(
home: Scaffold(
body: Column(
children: <Widget>[
WebLinkDelegate(
TestLinkInfo(
uri: Uri.parse('https://dart.dev/xyz'),
target: LinkTarget.blank,
builder: (BuildContext context, FollowLink? followLink) {
return ElevatedButton(
onPressed: followLink,
child: const Text('First Button'),
);
},
),
),
],
),
),
));

await tester.pumpAndSettle();
final SemanticsHandle handle = tester.ensureSemantics();

final Finder firstButtonFinder = find.text('First Button');
expect(firstButtonFinder, findsOneWidget);

final SemanticsNode firstSemantics =
tester.getSemantics(firstButtonFinder);
final SemanticsData firstData = firstSemantics.getSemanticsData();

handle.dispose();
expect(
firstData.hasFlag(SemanticsFlag.isLink),
isTrue,
reason: 'Button should be treated as link with excludeSemantics: true',
);

expect(firstData.hasFlag(SemanticsFlag.isButton), isFalse,
reason:
'semantics should be excluded to prevent TAB navigation conflicts',
skip: true);

expect(firstData.linkUrl?.toString(), equals('https://dart.dev/xyz'));
handle.dispose();
});
});

group('Follows links', () {
Expand Down
1 change: 1 addition & 0 deletions packages/url_launcher/url_launcher_web/lib/src/link.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ class WebLinkDelegateState extends State<WebLinkDelegate> {
Widget _buildChild(BuildContext context) {
return Semantics(
link: true,
excludeSemantics: true,
identifier: _semanticsIdentifier,
linkUrl: widget.link.uri,
child: widget.link.builder(
Expand Down