-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[video_player_web] Fix: The play() request was interrupted by end of playback. https://goo.gl/LdLk22 #9809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an issue where benign video playback interruptions on the web were being reported as errors. It introduces a check to specifically ignore DOMException
s related to these interruptions, making the error handling more robust. Additionally, some minor code formatting changes are included. My review suggests a refinement to the error checking logic to rely on the exception's name
property instead of its message string for better reliability across different web browsers.
final String message = exception.message; | ||
if (message.contains('The play() request was interrupted')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relying on the exception's message string can be brittle, as it may change between browser versions or not be consistent across different browsers.
A more robust method is to check the exception.name
. According to web standards and the linked article, playback interruptions should raise a DOMException
with the name AbortError
. This change makes the check more reliable and removes the need for the now-unused message
variable.
if (exception.name == 'AbortError') {
Thanks for the contribution! Since most of the items in the PR checklist haven't been done yet, I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review. |
Fix: The play() request was interrupted by end of playback. https://g…
…oo.gl/LdLk22
When I try to play a video with a unique frame, it throws the error above, the best fix I found was just ignore the error since it is just a warning and the remain implementation is correct.
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assist
bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3