-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[ci] Remove mustache_template from allowed external deps #10427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mustache_template was moved into this repository, so is no longer an external dependency that requires an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the script/configs/allowed_pinned_deps.yaml file to remove mustache_template from the list of allowed pinned external dependencies. According to the pull request description, this is because the package has been moved into the repository. The change is correct and aligns with this reasoning. I have no further feedback.
flutter/packages@799b62c...ce44ebb 2025-11-17 [email protected] Kgp bulk update (flutter/packages#10412) 2025-11-16 [email protected] [camera_avfoundation] Wrappers swift migration - part 3 (flutter/packages#10293) 2025-11-15 [email protected] [ci] Update Flutter version for `release` (flutter/packages#10425) 2025-11-15 [email protected] Manual roll Flutter from c3f2704 to 9b5ad80 (2 revisions) (flutter/packages#10435) 2025-11-14 [email protected] Manual roll Flutter from ee23168 to c3f2704 (5 revisions) (flutter/packages#10433) 2025-11-14 [email protected] [ci] Remove mustache_template from allowed external deps (flutter/packages#10427) 2025-11-14 [email protected] [animations] Clarify that onClosed is called before transition (flutter/packages#10400) 2025-11-14 [email protected] [web_benchmarks] Report correct expected metrics for wasm (flutter/packages#10236) 2025-11-13 [email protected] [google_maps_flutter] Set properties before adding maps objects (flutter/packages#10347) 2025-11-13 [email protected] Roll Flutter (stable) from a0e9b9d to b45fa18 (3 revisions) (flutter/packages#10420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#178649) flutter/packages@799b62c...ce44ebb 2025-11-17 [email protected] Kgp bulk update (flutter/packages#10412) 2025-11-16 [email protected] [camera_avfoundation] Wrappers swift migration - part 3 (flutter/packages#10293) 2025-11-15 [email protected] [ci] Update Flutter version for `release` (flutter/packages#10425) 2025-11-15 [email protected] Manual roll Flutter from c3f2704 to 9b5ad80 (2 revisions) (flutter/packages#10435) 2025-11-14 [email protected] Manual roll Flutter from ee23168 to c3f2704 (5 revisions) (flutter/packages#10433) 2025-11-14 [email protected] [ci] Remove mustache_template from allowed external deps (flutter/packages#10427) 2025-11-14 [email protected] [animations] Clarify that onClosed is called before transition (flutter/packages#10400) 2025-11-14 [email protected] [web_benchmarks] Report correct expected metrics for wasm (flutter/packages#10236) 2025-11-13 [email protected] [google_maps_flutter] Set properties before adding maps objects (flutter/packages#10347) 2025-11-13 [email protected] Roll Flutter (stable) from a0e9b9d to b45fa18 (3 revisions) (flutter/packages#10420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mustache_template was moved into this repository, so is no longer an external dependency that requires an exception.