Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Oct 28, 2025

Fixes flutter/flutter#173326

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@bparrishMines bparrishMines changed the title fix crash [webview_flutter_wkwebview] Fixes crash when running WKNavigationResponse tests on Xcode 26 Oct 28, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a crash that occurs during testing by introducing a singleton pattern for TestNavigationResponse. By using a static instance, it prevents premature deallocation of WKNavigationResponse objects within the test environment, which was causing the crash. The changes are correctly applied across the test files.

To align with the repository's contribution guidelines, please update the pull request title to include the package name (e.g., [webview_flutter_wkwebview] Fix crash in tests) and fill out the PR description with the necessary details, including the checklist and a link to the issue this PR resolves.

I have one suggestion to make the singleton implementation more robust.

Comment on lines +35 to +36
static let instance = TestNavigationResponse()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To fully enforce the singleton pattern and prevent accidental creation of new TestNavigationResponse instances elsewhere in the tests, it's a good practice to make the initializer private. This will prevent reintroducing the deallocation crash in the future.

  static let instance = TestNavigationResponse()

  private override init() {
    super.init()
  }

@bparrishMines bparrishMines requested a review from jmagman October 28, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webview_flutter_wkwebview tests crash during -[WKNavigationResponse dealloc] on Xcode 26 beta 4

1 participant