Skip to content

[video_player] Add audio track management support to platform interface #10171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 27, 2025
Merged

[video_player] Add audio track management support to platform interface #10171

merged 9 commits into from
Oct 27, 2025
+142 −1

Conversation

@nateshmbhat
Copy link
Contributor

@nateshmbhat nateshmbhat commented Oct 4, 2025

Description

platform interface pr for #9925

Core Features

  • Added VideoAudioTrack model with comprehensive metadata fields: id, label, language, isSelected, bitrate, sampleRate, channelCount, codec
  • Added getAudioTracks() method to retrieve all available audio tracks with real metadata
  • Added selectAudioTrack() method to switch between audio tracks during playback

Breaking Changes

None - all changes are additive and backward compatible.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [video_player]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 4, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 4, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces audio track management capabilities to the video_player platform interface. It adds a new VideoAudioTrack model to represent audio track metadata, and new methods getAudioTracks(), selectAudioTrack(), and isAudioTrackSupportAvailable() to the VideoPlayerPlatform abstract class. The changes are well-structured and additive. My review includes a suggestion to add tests for the new platform interface methods and a minor improvement to the changelog entry for completeness.

@nateshmbhat nateshmbhat mentioned this pull request Oct 4, 2025
Open
11 tasks
tarrinneal
tarrinneal reviewed Oct 11, 2025
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemini's comments are good this time. Would implement them.

@nateshmbhat
Copy link
Contributor Author

nateshmbhat commented Oct 13, 2025 •
edited
Loading

have updated PR as per gemini's suggestions @tarrinneal

stuartmorgan-g
stuartmorgan-g requested changes Oct 15, 2025
View reviewed changes
@stuartmorgan-g stuartmorgan-g changed the title feat(video_player): add audio track management support to platform interface [video_player] Add audio track management support to platform interface Oct 16, 2025
stuartmorgan-g
stuartmorgan-g approved these changes Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

tarrinneal
tarrinneal approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once @stuartmorgan-g 's comments are addressed?

@nateshmbhat
chore(video_player): enhance audio track documentation and changelog
926f784 
- Added detailed documentation comments for VideoAudioTrack properties explaining null cases
- Updated CHANGELOG.md to use more concise language for audio track management features
- Improved code readability by adding spacing between property documentation blocks
stuartmorgan-g
stuartmorgan-g approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2025
@auto-submit auto-submit bot merged commit 9905c4a into flutter:main Oct 27, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 28, 2025
@engine-flutter-autoroll
9905c4aff [video_player] Add audio track management support to platfo…
caf2682 
…rm interface (flutter/packages#10171)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 28, 2025
@engine-flutter-autoroll
9905c4aff [video_player] Add audio track management support to platfo…
39af23a 
…rm interface (flutter/packages#10171)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 28, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Oct 28, 2025
@engine-flutter-autoroll
Roll Packages from bbf96a0755af to c8ba0cc1e7bb (2 revisions) (#177672)
1714fee 
flutter/packages@bbf96a0...c8ba0cc

2025-10-27 [email protected] Fix Namespace Assignment Test
(flutter/packages#10289)
2025-10-27 [email protected] [video_player] Add audio track
management support to platform interface (flutter/packages#10171)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
walley892 pushed a commit to walley892/flutter that referenced this pull request Oct 30, 2025
@engine-flutter-autoroll @walley892
Roll Packages from bbf96a0755af to c8ba0cc1e7bb (2 revisions) (flutte…
dba0f40 
…r#177672)

flutter/packages@bbf96a0...c8ba0cc

2025-10-27 [email protected] Fix Namespace Assignment Test
(flutter/packages#10289)
2025-10-27 [email protected] [video_player] Add audio track
management support to platform interface (flutter/packages#10171)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: video_player

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nateshmbhat @stuartmorgan-g @tarrinneal