Fixes FlutterSemanticsScrollView to not implement accessibility conta… #28846
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I can probably write a test that expect whatever the default implementation those selector return if not implemented, but it may break if it changes in the future update, and it feels unnecessary |
|
test-exempt: only removes code |
Ignoring the web framework test since the failure originates from a repo synchronization issue between engine and framework. The new failing tests were sync'ed in from head in the test and the tested code doesn't exist in the engine at the time of branch cut. * Fixes FlutterSemanticsScrollView to not implement accessibility container API (#28846) * add branch to test * Replace jcenter() for mavenCentral() (#28777) * Set MinimumOSVersion to iOS 9 in Info.plist (#28783) * Do not use jcenter(), switch to mavenCentral() (#28738) Co-authored-by: chunhtai <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Dan Field <[email protected]>
| @@ -106,33 +106,4 @@ - (NSInteger)accessibilityElementCount { | |||
| return [[_semanticsObject children] count]; | |||
There was a problem hiding this comment.
@chunhtai Should we remove this method too?
…iner API
Implementing the accessibility contain API makes voiceover confused since we have our own way of handling accessibility container
fixes flutter/flutter#90681
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.