Skip to content

ci: add update tests about service status #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

ci: add update tests about service status #681

merged 1 commit into from
Oct 23, 2024

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Oct 2, 2024 •
edited
Loading

There is specification difference between DEB and RPM.

At least, there should be tests to clarify the current specification.

The current specification:

  • DEB
    • The service is enabled by default.
    • The service starts automatically after new install.
    • The service starts automatically when it was active OR enabled before update.
  • RPM
    • The service is disabled by default.
    • The service does not start automatically after new install.
    • The service starts automatically only when it was active before update.

@daipom daipom force-pushed the ci-add-update-tests branch 3 times, most recently from a123910 to 09ab95b Compare October 2, 2024 07:20
@daipom daipom force-pushed the ci-add-update-tests branch from 09ab95b to ae5a127 Compare October 22, 2024 05:00
@daipom
Copy link
Contributor Author

daipom commented Oct 22, 2024

Rebased to the latest master.

@daipom daipom force-pushed the ci-add-update-tests branch from 62ab0a8 to 18a995d Compare October 22, 2024 08:14
@daipom
Copy link
Contributor Author

daipom commented Oct 22, 2024

I have refactored the codes.
Confirming CI...

@daipom
ci: add update tests
f2c43be 
There is specification difference between DEB and RPM.
At least, there should be tests to clarify the current
specification.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom force-pushed the ci-add-update-tests branch from 18a995d to f2c43be Compare October 22, 2024 08:45
@daipom daipom marked this pull request as ready for review October 22, 2024 09:50
@daipom daipom changed the title ci: add update tests ci: add update tests about service status Oct 22, 2024
@daipom daipom requested review from kenhys and Watson1978 October 22, 2024 09:50
@daipom daipom mentioned this pull request Oct 22, 2024
Merged
Watson1978
Watson1978 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

kenhys
kenhys approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 4a5caae into fluent:master Oct 23, 2024
101 checks passed
@daipom daipom deleted the ci-add-update-tests branch October 23, 2024 02:30
@daipom
Copy link
Contributor Author

daipom commented Oct 23, 2024

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Watson1978 Watson1978 Watson1978 approved these changes

@kenhys kenhys kenhys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daipom @Watson1978 @kenhys