build: remove buster, replace with bullseye when necessary #10908

aminvakil · 2025-09-19T14:03:48Z

It's been three years since buster does not gets updated from Debian Security Team and it's been a year since Debian LTS Team does not support that either.

Now that trixie has been added as well to this repository, I've removed all buster tests.

There were also some tests which only were tested on buster, I've changed them to bullseye for now to expect minimum changes, and I'm going to change them to trixie with is Debian stable now.

Enter `` in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

[N/A] Example configuration file for the change
[N/A] Debug log output from testing the change
[N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Run local packaging test showing all targets (including any new ones) build.
Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

Documentation required for this feature

fluent/fluent-bit-docs#2068

Backporting

[N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

Chores
- Updated build pipeline infrastructure to use Debian Bullseye, replacing Debian Buster across all builds.
- Removed Debian Buster from supported build targets and repository configurations.

patrick-stephens

I would disable the build but not remove the option for folks to build, I know it's eol but that's not the same as no one uses it (look at Centos). We can just remove it from all the CI but leave the container definition I think.

aminvakil · 2025-09-19T14:36:32Z

I would disable the build but not remove the option for folks to build, I know it's eol but that's not the same as no one uses it (look at Centos). We can just remove it from all the CI but leave the container definition I think.

65c15b4

Does this suffice?

patrick-stephens · 2025-09-20T19:06:30Z

.github/actions/generate-package-build-matrix/action.yaml

          echo '{ "distro" : ['
          echo '"amazonlinux/2", "amazonlinux/2.arm64v8",'
          echo '"centos/7", "centos/7.arm64v8", "centos/8", "centos/8.arm64v8",'
-          echo '"debian/buster", "debian/buster.arm64v8", "debian/bullseye", "debian/bullseye.arm64v8",'


No need to change this, it's only for 1.9 and earlier builds

patrick-stephens · 2025-09-20T19:08:20Z

packaging/distros/raspbian/Dockerfile

 # Use buildkit to skip unused base images: DOCKER_BUILDKIT=1

-FROM balenalib/rpi-raspbian:buster AS raspbian-buster-base
+FROM balenalib/rpi-raspbian:bullseye AS raspbian-bullseye-base


This is actually changing the Raspbian build, I'm not sure we want that as it's not Debian per-se. Not sure why we jumped from buster to bookworm for Raspbian but that's not part of this change.

Please make sure you're not just globally changing any reference to the string.

patrick-stephens · 2025-09-20T19:09:16Z

packaging/testing/smoke/packages/Dockerfile.debian10

@@ -1,11 +1,11 @@
 # For staging upgrade we use the 'official-install' as the base
-ARG STAGING_BASE=docker.io/dokken/debian-10
+ARG STAGING_BASE=docker.io/dokken/debian-11


Again, this is a change that is confusing as the file we are in here is called .debian10, I think it's been a global search-and-replace when instead we should also rename the file to be clear and accurate.

Sorry, this was a mistake and I have reverted this.

Yes. It was a global search-and-replace. I wasn't sure if this file is still needed, so I have not removed it and just reverted my wrong change.

aminvakil · 2025-09-26T11:26:56Z

None of failing tests are related to this PR.

coderabbitai · 2025-09-26T11:27:28Z

Walkthrough

This pull request removes support for Debian Buster and upgrades CI workflows to use Debian Bullseye across multiple library modules. Changes include updating container images in four build workflows and removing deprecated Buster targets from packaging configuration files and documentation.

Changes

Cohort / File(s)	Summary
CI workflow container upgrades `lib/cfl/.github/workflows/build.yaml`, `lib/cmetrics/.github/workflows/build.yaml`, `lib/cprofiles/.github/workflows/build.yaml`, `lib/ctraces/.github/workflows/build.yaml`	Updated Debian build job container image from `debian:buster` to `debian:bullseye` and updated job display names accordingly.
Packaging target configuration `packaging/build-config.json`, `packaging/update-repos.sh`	Removed `debian/buster` and `debian/buster.arm64v8` targets from build configuration and DEB_REPO_PATHS array.
Documentation and comments `packaging/README.md`, `packaging/update-apt-repo.sh`	Removed Debian Buster (x86_64 and arm64v8) entries from distribution table and removed `debian/buster` and `raspbian/buster` from deployment target comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

These are homogeneous deprecation changes applied consistently across multiple files with straightforward logic—straightforward removals and container image updates. The repetitive nature and low density of changes allow for efficient parallel verification across all modified files.

Possibly related PRs

packaging: add debian trixie support #10728: Modifies packaging and repository configuration similarly, touching DEB_REPO_PATHS and packaging build targets.

Suggested reviewers

niedbalski
patrick-stephens
celalettin1286

Poem

🐰 Buster's day has come to pass,
Bullseye now takes center class,
Workflows leap, configs rearrange,
Our CI homes embrace the change! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "build: remove buster, replace with bullseye when necessary" accurately reflects the core changes in the changeset. The PR removes Debian Buster from build workflows and configurations (lib/cfl, lib/cmetrics, lib/cprofiles, lib/ctraces, packaging/build-config.json, packaging/update-repos.sh, and packaging/update-apt-repo.sh) and replaces those Buster builds with Bullseye in the workflow files to maintain testing continuity. The title is concise, specific enough for someone reviewing history to understand the primary change, and directly related to the main objective stated in the PR description (removing EOL Buster support while transitioning affected tests to Bullseye).
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 586e9b3 and 8513540.

📒 Files selected for processing (8)

lib/cfl/.github/workflows/build.yaml (1 hunks)
lib/cmetrics/.github/workflows/build.yaml (1 hunks)
lib/cprofiles/.github/workflows/build.yaml (1 hunks)
lib/ctraces/.github/workflows/build.yaml (1 hunks)
packaging/README.md (0 hunks)
packaging/build-config.json (0 hunks)
packaging/update-apt-repo.sh (1 hunks)
packaging/update-repos.sh (0 hunks)

💤 Files with no reviewable changes (3)

packaging/update-repos.sh
packaging/build-config.json
packaging/README.md

🚧 Files skipped from review as they are similar to previous changes (4)

lib/cmetrics/.github/workflows/build.yaml
lib/cprofiles/.github/workflows/build.yaml
lib/ctraces/.github/workflows/build.yaml
lib/cfl/.github/workflows/build.yaml

🔇 Additional comments (1)

packaging/update-apt-repo.sh (1)

13-13: Documentation update is accurate.

The comment correctly reflects the removal of Buster from supported DEB_REPO targets, aligning with the PR's objective to deprecate Debian Buster. The documented targets are now consistent with the repository's updated support matrix.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

eschabell · 2025-10-21T12:07:24Z

@patrick-stephens can you approve this to get it merged?

Docs PR fluent/fluent-bit-docs#2068 ready to go.

patrick-stephens · 2025-10-21T19:30:45Z

src/wamrc/CMakeLists.txt

      DESTINATION "${FLB_INSTALL_BINDIR}")
  endif()
-endif ()
+endif ()


You should not be changing this, it's a vendored dependency so unrelated to this change.

I'm pretty sure this is vim vs vscode default behvaiour with newline, I didn't intend to change this :)

I'll revert this.

Signed-off-by: Amin Vakil <[email protected]>

aminvakil requested review from celalettin1286, edsiper, fujimotos, koleini, niedbalski and patrick-stephens as code owners September 19, 2025 14:03

github-actions bot added the docs-required label Sep 19, 2025

aminvakil mentioned this pull request Sep 19, 2025

packaging: remove buster fluent/fluent-bit-docs#2068

Open

patrick-stephens reviewed Sep 19, 2025

View reviewed changes

patrick-stephens reviewed Sep 20, 2025

View reviewed changes

aminvakil force-pushed the remove_buster branch 2 times, most recently from 3a514d9 to 6304625 Compare September 20, 2025 23:14

aminvakil force-pushed the remove_buster branch from 6304625 to 586e9b3 Compare September 26, 2025 11:27

patrick-stephens reviewed Oct 21, 2025

View reviewed changes

aminvakil force-pushed the remove_buster branch from 586e9b3 to 79f3eb2 Compare October 22, 2025 10:50

aminvakil added 6 commits October 22, 2025 14:22

build: remove buster, replace with bullseye when necessary

9b311a5

Signed-off-by: Amin Vakil <[email protected]>

Add buster Dockerfile back

0719ac3

Signed-off-by: Amin Vakil <[email protected]>

Revert raspbian Dockerfile changes

df3188d

Signed-off-by: Amin Vakil <[email protected]>

Revert Dockerfile.debian10 changes

dff188e

Signed-off-by: Amin Vakil <[email protected]>

Revert 1.9 action.yaml changes

88afa51

Signed-off-by: Amin Vakil <[email protected]>

Restore src/wamrc/CMakeLists.txt change

8513540

Signed-off-by: Amin Vakil <[email protected]>

aminvakil force-pushed the remove_buster branch from 694466f to 8513540 Compare October 22, 2025 10:53

build: remove buster, replace with bullseye when necessary #10908

Are you sure you want to change the base?

build: remove buster, replace with bullseye when necessary #10908

Conversation

aminvakil commented Sep 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

patrick-stephens left a comment

Choose a reason for hiding this comment

Uh oh!

aminvakil commented Sep 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aminvakil commented Sep 26, 2025

Uh oh!

coderabbitai bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

eschabell commented Oct 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aminvakil commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 26, 2025 •

edited

Loading