Fixed error message for connection exceptions #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tPl0ch could you please check this PR? |
Contributor
Author
|
Omg I have this tests failed in master branch 😅 |
Contributor
Author
|
@tPl0ch looks like you haven't set a new tag in Latest fix from master branch solves this tests |
Elnadrion
force-pushed
the
fix/connect-exceptions
branch
from
ff9c2ea to
d4ccd80
Compare
Merged
Collaborator
|
@Elnadrion |
Contributor
Author
|
I |
Contributor
Author
|
I haven't pulled new CI checks though. 1 sec |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
There is only handling of Guzzle RequestExceptions. When my team and I got another type of exception - package drives us crazy with it's message 😅 I've changed this behavior, and turn this:
into this: