Add imagen editing cases to the Firebase AI quickstart #2702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmotson
changed the title
ryanwilson
reviewed
Jul 23, 2025
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/MainActivity.kt
Outdated
Show resolved
Hide resolved
|
Please add a description to the PR |
rlazo
reviewed
Jul 23, 2025
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
...-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenScreen.kt
Outdated
Show resolved
Hide resolved
...-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenScreen.kt
Outdated
Show resolved
Hide resolved
.../app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenViewModel.kt
Outdated
Show resolved
Hide resolved
thatfiredev
requested changes
Aug 6, 2025
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/Sample.kt
Outdated
Show resolved
Hide resolved
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/MainActivity.kt
Show resolved
Hide resolved
…o attached images to speed up generation time
|
Can we make the alignment a dropdown and add a label so it's clear what the values mean? The current setup isn't super intuitive. See screenshot 
|
|
Also, probably "Select" is better? Additionally, can we make the buttons be side by side? 
|
rlazo
reviewed
Aug 18, 2025
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
rlazo
reviewed
Aug 18, 2025
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
|
Style transfer is not a very clear example since we can't see the image of the cat used as style reference. When running it, it was not clear what image it was expecting me to upload, and it was not clear what the reference style image was going to be, since I can't see it outside the code review 
|
added 5 commits
August 19, 2025 09:07
rlazo
approved these changes
Aug 20, 2025
rlazo
requested changes
Aug 20, 2025
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
...-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenScreen.kt
Outdated
Show resolved
Hide resolved
...-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenScreen.kt
Outdated
Show resolved
Hide resolved
rlazo
reviewed
Aug 20, 2025
...-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenScreen.kt
Outdated
Show resolved
Hide resolved
added 2 commits
August 20, 2025 14:39
rlazo
approved these changes
Aug 21, 2025
thatfiredev
requested changes
Aug 22, 2025
.../app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenViewModel.kt
Show resolved
Hide resolved
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/Sample.kt
Outdated
Show resolved
Hide resolved
.../app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenViewModel.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Imagen Editing cases to the quickstart including: