Quickstart updates #1188
Merged
Quickstart updates #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly specific activity for callbackbinding, use PhoneAuthOptions
malcolmdeck
reviewed
Oct 6, 2020
auth/app/src/main/java/com/google/firebase/quickstart/auth/java/PhoneAuthActivity.java
Outdated
Show resolved
Hide resolved
malcolmdeck
reviewed
Oct 6, 2020
auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/PhoneAuthActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Oct 28, 2020
Comment on lines
160
to
161
| .build(); | ||
| PhoneAuthProvider.verifyPhoneNumber(options); |
There was a problem hiding this comment.
Suggested change
| .build(); | |
| PhoneAuthProvider.verifyPhoneNumber(options); | |
| .build() | |
| PhoneAuthProvider.verifyPhoneNumber(options) |
Comment on lines
185
to
186
| .build(); | ||
| PhoneAuthProvider.verifyPhoneNumber(options); |
There was a problem hiding this comment.
Suggested change
| .build(); | |
| PhoneAuthProvider.verifyPhoneNumber(options); | |
| .build() | |
| PhoneAuthProvider.verifyPhoneNumber(options) |
This was referenced Sep 1, 2023
This was referenced Sep 16, 2023
This was referenced Sep 23, 2023
This was referenced Oct 14, 2023
This was referenced Nov 7, 2023
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly specific activity for callback binding, use PhoneAuthOptions