Skip to content

refactor(admob, analytics): replace deprecated methods #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2020
Merged

refactor(admob, analytics): replace deprecated methods #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ae40e2
refactor(admob): replace deprecated MobileAds.initialize(context, str…
thatfiredev Sep 17, 2020
bbd7ef7
refactor(analytics): replace deprecated setCurrentScreen()
thatfiredev Sep 17, 2020
17a9663
Update MainActivity.kt
thatfiredev Sep 24, 2020
0f1a1f3
Update MainActivity.java
thatfiredev Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admob/app/src/main/java/com/google/samples/quickstart/admobexample/java/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ protected void onCreate(Bundle savedInstanceState) {
checkIds();

// Initialize the Google Mobile Ads SDK
MobileAds.initialize(this, getString(R.string.admob_app_id));
MobileAds.initialize(this);

mAdView = findViewById(R.id.adView);
AdRequest adRequest = new AdRequest.Builder().build();
Expand Down
2 changes: 1 addition & 1 deletion admob/app/src/main/java/com/google/samples/quickstart/admobexample/kotlin/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class MainActivity : AppCompatActivity() {
checkIds()

// Initialize the Google Mobile Ads SDK
MobileAds.initialize(this, getString(R.string.admob_app_id))
MobileAds.initialize(this)

val adRequest = AdRequest.Builder().build()

Expand Down
7 changes: 5 additions & 2 deletions analytics/app/src/main/java/com/google/firebase/quickstart/analytics/java/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,14 @@ private void recordImageView() {
* we change fragments.
*/
private void recordScreenView() {
// This string must be <= 36 characters long in order for setCurrentScreen to succeed.
// This string must be <= 36 characters long.
String screenName = getCurrentImageId() + "-" + getCurrentImageTitle();

// [START set_current_screen]
mFirebaseAnalytics.setCurrentScreen(this, screenName, null /* class override */);
Bundle bundle = new Bundle();
bundle.putString(FirebaseAnalytics.Param.SCREEN_NAME, screenName);
bundle.putString(FirebaseAnalytics.Param.SCREEN_CLASS, "MainActivity");
mFirebaseAnalytics.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW, bundle);
// [END set_current_screen]
}

Expand Down
7 changes: 5 additions & 2 deletions analytics/app/src/main/java/com/google/firebase/quickstart/analytics/kotlin/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,14 @@ class MainActivity : AppCompatActivity() {
* we change fragments.
*/
private fun recordScreenView() {
// This string must be <= 36 characters long in order for setCurrentScreen to succeed.
// This string must be <= 36 characters long.
val screenName = "${getCurrentImageId()}-${getCurrentImageTitle()}"

// [START set_current_screen]
firebaseAnalytics.setCurrentScreen(this, screenName, null /* class override */)
firebaseAnalytics.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW) {
param(FirebaseAnalytics.Param.SCREEN_NAME, screenName)
param(FirebaseAnalytics.Param.SCREEN_CLASS, "MainActivity")
}
// [END set_current_screen]
}

Expand Down